Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reloader App #3717

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add Reloader App #3717

wants to merge 4 commits into from

Conversation

Sleuth56
Copy link

A very basic app to reload the Banglejs2 after an amount of time has passed. The goal of this app is to prevent crashing and memory leaks.

@thyttan
Copy link
Collaborator

thyttan commented Jan 17, 2025

Hi - thanks for your first PR! 🚀

I'm personally a little hesitant towards this approach. Could you please provide some background to why you needed this in the first place? Both as a rationale for the PR and so we can maybe fix the original problem.

Ideally we should strive to make the code on the watch not crash and not have memory leaks. If we can identify problems we should track and fix them.

When/if we pull this in I think we should add a paragraph in the readme asking for the user to report the problem that caused them to install the Reloader app.

From the wiki (doesn't apply entirely to this reloader app though but is part of the basis of my skepticism):

# For modifications to existing apps/modules:
[...]
- Avoid hacks to work around particular problems. If something is broken in some other part of Bangle.js then ideally we should raise a bug for that and fix it, rather than adding a hack to every app that wants to use that functionality.

https://github.com/espruino/BangleApps/wiki/App-Contribution#for-modifications-to-existing-appsmodules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants