Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip copy for given container registry domain #865

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jetersen
Copy link

@jetersen jetersen commented Jan 19, 2025

Since AWS has added more options for pull through cache on ECR.

I would prefer to use that but there a still unsupported image sources. Not all registries are supported so this provides the flexibility to skip the once ECR Pull through cache handles.

There is still a benefit to k8s-image-swapper since it supports the image swap on a pod level. Cause we want use tooling to detect changes to the images we use on a higher level than the pod.

Currently ECR supports:

  • public.ecr.aws
  • registry-1.docker.io
  • registry.k8s.io
  • quay.io
  • ghcr.io
  • *.azurecr.io
  • registry.gitlab.com

So far we have come across other image sources we use that are not supported by ECR pull through:

  • registry.opensource.zalan.do
  • us-docker.pkg.dev
  • xpkg.upbound.io

image
image

@jetersen
Copy link
Author

@estahn not sure what your notification settings are so, I'll allow myself to ping you 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant