-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: raise library test coverage #349
Conversation
…MSRV bump, cleanup color ctrl test
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
===========================================
+ Coverage 63.01% 84.61% +21.59%
===========================================
Files 24 24
Lines 1560 1566 +6
===========================================
+ Hits 983 1325 +342
+ Misses 577 241 -336 ☔ View full report in Codecov by Sentry. |
1a1ccd8
to
3d157d5
Compare
3d157d5
to
587fe47
Compare
aadede8
to
0b8215d
Compare
b449689
to
3bf0d57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for review
1. Ensure the archives are small enough that the compression time is acceptable. | ||
|
||
For more information see the PR that added [`background_rotation`](https://github.com/estk/log4rs/pull/117). | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why rm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, i just pulled the thread and although gzip is no-longer part of the default features, I still think a warning regarding the use of gzip is important to be featured in the readme... perhaps not as prominently. Also, this change should be pulled out into a separate PR.
I think we should break this up into a few separate PR's, there are too many disparate changes here to review it without sitting down for at least a few hours... which is difficult to find these days. Can you please open separate PR's with cohesive motif's? Some possible MR's
In each PR please:
|
Broke into the following PRs: |
Fixes #352 + Adds a ton of tests