Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kurtosis-devnet): add non-trivial smoke test #13778

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sigma
Copy link
Contributor

@sigma sigma commented Jan 15, 2025

Description

This checks L2 to L2 messages against an interop devnet.

Note that currently the test fails pending changes in progress in defi-wonderland#192
So it fails for a good reason, which is good :)

Tests

Additional context

Metadata

@sigma sigma requested a review from a team as a code owner January 15, 2025 00:58
@sigma sigma requested a review from blmalone January 15, 2025 00:58
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.86%. Comparing base (107948c) to head (2331564).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13778      +/-   ##
===========================================
- Coverage    47.01%   42.86%   -4.16%     
===========================================
  Files          958      792     -166     
  Lines        80032    70665    -9367     
  Branches       758        0     -758     
===========================================
- Hits         37630    30291    -7339     
+ Misses       39546    37738    -1808     
+ Partials      2856     2636     -220     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 178 files with indirect coverage changes

@sigma sigma force-pushed the sigma/kurtosis-devnet-pq-45 branch from e02406e to d486eab Compare January 15, 2025 01:03
@sigma
Copy link
Contributor Author

sigma commented Jan 15, 2025

note: this is pretty horrible code right now, but I'd rather make it available early, and iterate

@tynes
Copy link
Contributor

tynes commented Jan 15, 2025

This is some sick bash

@sigma
Copy link
Contributor Author

sigma commented Jan 15, 2025

This is some sick bash

hey, it passes shellcheck, so it must be ok :)
Jokes aside, I definitely need to clean that mess up

@sigma sigma force-pushed the sigma/kurtosis-devnet-pq-45 branch from d486eab to a5ae6bd Compare January 15, 2025 17:57
@sigma sigma force-pushed the sigma/kurtosis-devnet-pq-45 branch from a5ae6bd to 2331564 Compare January 15, 2025 18:00
@sigma
Copy link
Contributor Author

sigma commented Jan 15, 2025

Should be much more readable now.
Note that there's a temporary hack to enable running within kurtosis. Need to adjust the environment files to do it properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants