Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AnchorStateRegistry as source of truth #13824

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

smartcontracts
Copy link
Contributor

Updates the OptimismPortal to use the AnchorStateRegistry as the source of truth for the validity of Dispute Game contracts.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 97.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.59%. Comparing base (003d648) to head (a54f238).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...kages/contracts-bedrock/src/L1/OptimismPortal2.sol 94.23% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13824      +/-   ##
===========================================
- Coverage    47.03%   45.59%   -1.44%     
===========================================
  Files          966      909      -57     
  Lines        80729    75966    -4763     
  Branches       774      769       -5     
===========================================
- Hits         37971    34639    -3332     
+ Misses       39831    38620    -1211     
+ Partials      2927     2707     -220     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests 89.03% <96.87%> (-2.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...deployer/pkg/deployer/opcm/dispute_game_factory.go 100.00% <ø> (ø)
op-deployer/pkg/deployer/pipeline/dispute_games.go 74.60% <100.00%> (-0.20%) ⬇️
...es/contracts-bedrock/src/L1/OPContractsManager.sol 94.03% <ø> (ø)
...contracts-bedrock/src/L1/OptimismPortalInterop.sol 100.00% <100.00%> (ø)
...tracts-bedrock/src/dispute/AnchorStateRegistry.sol 100.00% <100.00%> (ø)
...ontracts-bedrock/src/safe/DeputyGuardianModule.sol 100.00% <100.00%> (ø)
...kages/contracts-bedrock/src/L1/OptimismPortal2.sol 96.90% <94.23%> (-0.19%) ⬇️

... and 82 files with indirect coverage changes

@smartcontracts smartcontracts force-pushed the sc/asr-sot branch 10 times, most recently from 249c748 to 531ac60 Compare January 17, 2025 20:26
Updates the OptimismPortal to use the AnchorStateRegistry as the
source of truth for the validity of Dispute Game contracts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant