always show L1BlockRef when GetBlobs failed #13825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci authorize a6ab528 |
mbaxter
reviewed
Jan 23, 2025
|
/ci authorize 130c3fa |
mbaxter
approved these changes
Jan 24, 2025
Merged
via the queue into
ethereum-optimism:develop
with commit Jan 24, 2025
2537f35
44 checks passed
samlaf
pushed a commit
to Layr-Labs/optimism
that referenced
this pull request
Jan 27, 2025
* always show L1BlockRef when GetBlobs failed * address comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when
blobsFromSidecarsfails, the error log is like this:It doesn't show
L1BlockRefwhich is very useful to diagnose the problem.This PR adds it back.