Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-challenger: Migrate config over to supporting multiple L2s #13833

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Jan 17, 2025

Description

Updates the op-challenger config and flags to support multiple L2 endpoints and network/configs.

It currently enforces that if single chain game types are active, then only one L2 config/endpoint can be specified. I don't think we'll need to support running a challenger that works for both single chain and interop chain games in the same DisputeGameFactory but if we do we can work out how to rationalise things then.

Tests

Updated unit tests.

Additional context

Builds on #13810

@ajsutton ajsutton requested review from a team as code owners January 17, 2025 16:20
@ajsutton ajsutton requested review from pauldowman and sebastianst and removed request for a team January 17, 2025 16:20
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 16.90141% with 118 lines in your changes missing coverage. Please review.

Project coverage is 42.66%. Comparing base (139a0a9) to head (562d910).

Files with missing lines Patch % Lines
op-challenger/flags/flags.go 4.61% 62 Missing ⚠️
op-dispute-mon/flags/flags.go 0.00% 27 Missing ⚠️
op-challenger/game/fault/trace/vm/executor.go 43.75% 9 Missing ⚠️
op-challenger/flags/vm_flag.go 0.00% 6 Missing ⚠️
...lenger/game/fault/trace/vm/kona_server_executor.go 25.00% 3 Missing and 3 partials ⚠️
op-challenger/game/fault/clients.go 0.00% 5 Missing ⚠️
.../game/fault/trace/vm/kona_super_server_executor.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           aj/challenger-lazy-clients   #13833      +/-   ##
==============================================================
- Coverage                       42.69%   42.66%   -0.04%     
==============================================================
  Files                             802      802              
  Lines                           71379    71417      +38     
==============================================================
- Hits                            30478    30470       -8     
- Misses                          38237    38284      +47     
+ Partials                         2664     2663       -1     
Files with missing lines Coverage Δ
op-challenger/config/config.go 93.91% <100.00%> (ø)
.../game/fault/trace/vm/op_program_server_executor.go 100.00% <100.00%> (ø)
.../game/fault/trace/vm/kona_super_server_executor.go 0.00% <0.00%> (ø)
op-challenger/game/fault/clients.go 0.00% <0.00%> (ø)
op-challenger/flags/vm_flag.go 45.45% <0.00%> (-7.18%) ⬇️
...lenger/game/fault/trace/vm/kona_server_executor.go 61.11% <25.00%> (-5.56%) ⬇️
op-challenger/game/fault/trace/vm/executor.go 58.55% <43.75%> (+2.52%) ⬆️
op-dispute-mon/flags/flags.go 9.41% <0.00%> (-4.15%) ⬇️
op-challenger/flags/flags.go 10.63% <4.61%> (-0.17%) ⬇️

... and 9 files with indirect coverage changes

Base automatically changed from aj/challenger-lazy-clients to develop January 17, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant