-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: MIME Type For Web3 URL in Auto Mode #7087
Conversation
File
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
Thank for writing it. I suggested some changes:
- Added that
<contentType>
must follow structure of a MIME type, or an error is thrown - Added that
<fileType>
must be recognized and translatable to a MIME type, or an error is thrown. - Use of the word "query parameter" instead of "query", more precise
Thanks!
EIPS/eip-7087.md
Outdated
|
||
The standard introduces three types of queries to determine the MIME type. | ||
|
||
- `mime.content=<contentType>`, where `<contentType>`, after URL decoding, sets `Content-Type` field in the response header; or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `mime.content=<contentType>`, where `<contentType>`, after URL decoding, sets `Content-Type` field in the response header; or | |
- `mime.content=<contentType>`, where `<contentType>` is a URL-encoded [MIME type](https://datatracker.ietf.org/doc/html/rfc6838). If the URL-decoded `<contentType>` does not follow the structure of a MIME type, an error is thrown. After URL decoding, `<contentType>` is set as the value of the `Content-Type` header of the response; or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EIP cannot use the external link. Going to remove the link here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do actually allow links to RFCs! See EIP-1 for details.
EIPS/eip-7087.md
Outdated
|
||
- `mime.content=<contentType>`, where `<contentType>`, after URL decoding, sets `Content-Type` field in the response header; or | ||
- `mime.type=<fileType>`, where `<fileType>` is the file suffix that determines `Content-Type` field in the response header; or | ||
- `mime.dataurl=(true|false)`, which determines whether to decode the returned EVM data and set the MIME type according to data URL standard. If the data cannot be parsed as data URL, an error will be returned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `mime.dataurl=(true|false)`, which determines whether to decode the returned EVM data and set the MIME type according to data URL standard. If the data cannot be parsed as data URL, an error will be returned. | |
- `mime.dataurl=(true|false)`, which determines whether to decode the returned EVM data and set the MIME type according to the [data URL standard](https://datatracker.ietf.org/doc/html/rfc2397). If the data cannot be parsed as data URL, an error will be returned. |
Co-authored-by: nand2 <[email protected]>
Co-authored-by: nand2 <[email protected]>
Also I just remember we discussed the mix |
The commit 8d9dfab (as a parent of f6c642a) contains errors. |
Co-authored-by: nand2 <[email protected]>
Hi! I am going to add more changes for the auto mode, please don't merge this pull request yet! Thanks. |
I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually. As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process. If there is relevant history here, please link to this PR from the new pull request. On behalf of the EIP Editors, I apologize for this inconvenience. |
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: