Simplified attestation subnet mapping #3735
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgeManning
force-pushed
the
simplified-subnet-mapping
branch
from
fea5847 to
6194a23
Compare
jimmygchen
reviewed
Jul 29, 2024
jimmygchen
reviewed
Oct 4, 2024
| @@ -116,8 +116,6 @@ DEPOSIT_CONTRACT_ADDRESS: 0x00000000219ab540356cBB839Cbe05303d7705Fa | |||
| GOSSIP_MAX_SIZE: 10485760 | |||
| # `2**10` (= 1024) | |||
| MAX_REQUEST_BLOCKS: 1024 | |||
| # `2**8` (= 256) | |||
| EPOCHS_PER_SUBNET_SUBSCRIPTION: 256 | |||
There was a problem hiding this comment.
I vague recall there was a discussion on this somewhere but I couldn't find it - does the rotation not provide any benefit?
jimmygchen
reviewed
Oct 4, 2024
| @@ -135,9 +133,6 @@ MESSAGE_DOMAIN_VALID_SNAPPY: 0x01000000 | |||
| SUBNETS_PER_NODE: 2 | |||
| # 2**8 (= 64) | |||
| ATTESTATION_SUBNET_COUNT: 64 | |||
| ATTESTATION_SUBNET_EXTRA_BITS: 0 | |||
| # ceillog2(ATTESTATION_SUBNET_COUNT) + ATTESTATION_SUBNET_EXTRA_BITS | |||
| ATTESTATION_SUBNET_PREFIX_BITS: 6 | |||
There was a problem hiding this comment.
Do we want to keep this as config, and update the comment to ceillog2(ATTESTATION_SUBNET_COUNT), so it doesn't need to be computed in compute_subscribed_subnet?
|
Anyway, I have, thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a continuation of #3623 and linked PR's and issues.
There is quite a bit of complexity in how we should map a node-id to a backbone gossipsub topic. I think a number of future PRs are required in to address each complexity in turn.
In Lighthouse, we plan to adopt this simple approach, whilst discussion can continue on potentially more complex forms of this mapping. This approach simplifies the current state of the mapping and allows us to take advantage of improved discovery searches, which is the primary motivation behind this.