Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Add test cases for partially withdrawable validator scenarios #4094

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

bshastry
Copy link
Contributor

Add test cases to verify partial withdrawal eligibility across different validator types and balance thresholds as specified in EIP-7251.

Test scenarios:

  • Compounding validators (0x02) at and around MAX_EFFECTIVE_BALANCE_ELECTRA
  • Legacy validators (0x01) at and around MAX_EFFECTIVE_BALANCE

@jtraglia jtraglia mentioned this pull request Jan 22, 2025
4 tasks
Copy link
Contributor

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@jtraglia
Copy link
Member

I've chatted with @bshastry some privately & there are some changes we'd like to make.

I will save this PR for the next release, the beta.2 release.

@bshastry
Copy link
Contributor Author

@jtraglia Thanks, I've incorporated your feedback. Looks ready for another round of review/merge.

Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @bshastry!

@jtraglia jtraglia merged commit 294db63 into ethereum:dev Jan 27, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants