Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p spec updates #139

Merged
merged 7 commits into from
Feb 8, 2024
Merged

p2p spec updates #139

merged 7 commits into from
Feb 8, 2024

Conversation

0xSulpiride
Copy link
Contributor

@0xSulpiride 0xSulpiride commented Jan 4, 2024

Description

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@0xSulpiride 0xSulpiride requested a review from ch4r10t33r January 4, 2024 09:25
@0xSulpiride
Copy link
Contributor Author

We need to agree on the size of MempoolId. The IPFS hash is 46 bytes, so I'd push for this PR - eth-infinitism/bundler-spec#19

@0xSulpiride
Copy link
Contributor Author

Also we need to switch to one bundler - one chain model - that will be a separate PR

@0xSulpiride 0xSulpiride marked this pull request as ready for review January 4, 2024 11:50
@0xSulpiride 0xSulpiride changed the base branch from master to develop January 10, 2024 12:41
@0xSulpiride 0xSulpiride mentioned this pull request Jan 15, 2024
8 tasks
@0xSulpiride 0xSulpiride changed the title wip: p2p spec updates p2p spec updates Jan 16, 2024
@0xSulpiride 0xSulpiride merged commit 9ad43e5 into develop Feb 8, 2024
1 of 2 checks passed
@0xSulpiride 0xSulpiride deleted the p2p-spec-updates branch February 8, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants