Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding tenderly simulation for userop validation #277

Merged
merged 8 commits into from
Feb 4, 2025
Merged

feat: adding tenderly simulation for userop validation #277

merged 8 commits into from
Feb 4, 2025

Conversation

nikhilkumar1612
Copy link
Contributor

Description

  • Added tenderly simulation for userop validation in unsafe mode.
  • Signature checks in unsafe mode.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

Screenshot 2025-01-28 at 10 30 56 PM

arddluma
arddluma requested changes Jan 28, 2025
View reviewed changes
Copy link
Member

@arddluma arddluma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to update version correctly in all files.

packages/executor/src/config.ts Outdated
@@ -346,6 +346,20 @@ export class Config {
)
);

config.tenderlyUrl = String(
fromEnvVar(
"TENDERLY_URL",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please call this TENDERLY_API_URL instead?

ch4r10t33r
ch4r10t33r approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I presume tenderly is supported on all EVM chains that we run the AA service in?

ch4r10t33r
ch4r10t33r reviewed Feb 4, 2025
View reviewed changes
packages/executor/src/services/UserOpValidation/GethTracer.ts Outdated
@@ -45,6 +45,7 @@ export class GethTracer {
},
"latest",
{
timeout: "10s",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this configurable?

ch4r10t33r
ch4r10t33r approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nikhilkumar1612 nikhilkumar1612 merged commit d9ac381 into master Feb 4, 2025
4 checks passed
@nikhilkumar1612 nikhilkumar1612 deleted the ft/tenderly branch February 4, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@arddluma arddluma arddluma approved these changes

@0xSulpiride 0xSulpiride Awaiting requested review from 0xSulpiride

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikhilkumar1612 @ch4r10t33r @arddluma