Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit error from google speech #43

Merged
merged 1 commit into from
May 21, 2017
Merged

Conversation

jaumard
Copy link
Contributor

@jaumard jaumard commented May 19, 2017

When Google Speech return an error, it's not emitted by sonus and we didn't know what append. This PR fix that

@evancohen evancohen merged commit 8d9b160 into evancohen:master May 21, 2017
@evancohen
Copy link
Owner

Thanks @jaumard! Good idea :)

@jaumard
Copy link
Contributor Author

jaumard commented May 21, 2017

No problem :) I think there some other problem around error management, I have no result/feedback when I have slow network :/

@evancohen
Copy link
Owner

evancohen commented May 21, 2017

I've had a tough time consistently reproducing that, but I've seen odd behavior on a slow network as well.
This fix addresses #34, but there might be more that we can do here for users with a slow connection - maybe just a configurable timeout?

@jaumard
Copy link
Contributor Author

jaumard commented May 21, 2017

Hum in fact if I understand correctly the #34 that's what I fix with this PR, now sonus emit an error event with the error object given by the google speech module. But still have a problem in slow network maybe because it doesn't stop after a timeout and keep trying. So a configurable timeout should fix the problem but it must force quit the current connexion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants