Comments on std hashmap bucket defaults.

evoskuil · Jan 13, 2025 · 66a7516 · 66a7516
1 parent f5440a3
commit 66a7516
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/include/bitcoin/node/chasers/chaser_organize.hpp b/include/bitcoin/node/chasers/chaser_organize.hpp
@@ -172,6 +172,8 @@ class chaser_organize
 
     // These are protected by strand.
     chain_state::ptr state_{};
+
+    // TODO: optimize, default bucket count is around 8.
     block_tree tree_{};
 };
 

diff --git a/include/bitcoin/node/protocols/protocol_block_in.hpp b/include/bitcoin/node/protocols/protocol_block_in.hpp
@@ -56,6 +56,7 @@ class BCN_API protocol_block_in
 
     struct track
     {
+        // TODO: optimize, default bucket count is around 8.
         hashmap ids{};
         size_t announced{};
         system::hash_digest last{};

diff --git a/include/bitcoin/node/sessions/session_outbound.hpp b/include/bitcoin/node/sessions/session_outbound.hpp
@@ -54,6 +54,7 @@ class BCN_API session_outbound
     const float allowed_deviation_;
 
     // This is protected by strand.
+    // TODO: optimize, default bucket count is around 8.
     std::unordered_map<object_key, double> speeds_{};
 };