Fix validate/confirm threadpool/strand initialization order.

include/bitcoin/node/chasers/chaser_confirm.hpp

@@ -87,15 +87,15 @@ class BCN_API chaser_confirm
     bool get_is_strong(bool& strong, const uint256_t& fork_work,
         size_t fork_point) const NOEXCEPT;
 
-    // These are thread safe.
-    const bool concurrent_;
-    network::asio::strand independent_strand_;
-
     // These are protected by strand.
-    network::threadpool threadpool_;
-    neutrino_header neutrino_{};
-    bool filters_{};
     bool mature_{};
+    bool filters_{};
+    neutrino_header neutrino_{};
+    network::threadpool threadpool_;
+
+    // These are thread safe.
+    network::asio::strand independent_strand_;
+    const bool concurrent_;
 };
 
 } // namespace node

include/bitcoin/node/chasers/chaser_validate.hpp

@@ -66,17 +66,17 @@ class BCN_API chaser_validate
         return backlog_ < maximum_backlog_;
     }
 
-    // These are thread safe.
-    const bool concurrent_;
-    const size_t maximum_backlog_;
-    const uint64_t initial_subsidy_;
-    const uint32_t subsidy_interval_;
-    network::asio::strand independent_strand_;
-
     // These are protected by strand.
-    network::threadpool threadpool_;
-    size_t backlog_{};
     bool mature_{};
+    size_t backlog_{};
+    network::threadpool threadpool_;
+
+    // These are thread safe.
+    network::asio::strand independent_strand_;
+    const uint32_t subsidy_interval_;
+    const uint64_t initial_subsidy_;
+    const size_t maximum_backlog_;
+    const bool concurrent_;
 };
 
 } // namespace node

src/chasers/chaser_confirm.cpp

@@ -41,9 +41,9 @@ BC_PUSH_WARNING(NO_THROW_IN_NOEXCEPT)
 // Higher priority than validator ensures locality to validator reads.
 chaser_confirm::chaser_confirm(full_node& node) NOEXCEPT
   : chaser(node),
-    concurrent_(node.config().node.concurrent_confirmation),
     threadpool_(one, node.config().node.priority_()),
-    independent_strand_(threadpool_.service().get_executor())
+    independent_strand_(threadpool_.service().get_executor()),
+    concurrent_(node.config().node.concurrent_confirmation)
 {
 }
 

src/chasers/chaser_validate.cpp

@@ -43,12 +43,12 @@ BC_PUSH_WARNING(NO_THROW_IN_NOEXCEPT)
 // Higher priority than downloader (net) ensures locality to downloader writes.
 chaser_validate::chaser_validate(full_node& node) NOEXCEPT
   : chaser(node),
-    concurrent_(node.config().node.concurrent_validation),
-    maximum_backlog_(node.config().node.maximum_concurrency_()),
-    initial_subsidy_(node.config().bitcoin.initial_subsidy()),
-    subsidy_interval_(node.config().bitcoin.subsidy_interval_blocks),
     threadpool_(node.config().node.threads_(), node.config().node.priority_()),
-    independent_strand_(threadpool_.service().get_executor())
+    independent_strand_(threadpool_.service().get_executor()),
+    subsidy_interval_(node.config().bitcoin.subsidy_interval_blocks),
+    initial_subsidy_(node.config().bitcoin.initial_subsidy()),
+    maximum_backlog_(node.config().node.maximum_concurrency_()),
+    concurrent_(node.config().node.concurrent_validation)
 {
 }