Handle numerical issues complex_numbers_spec.cr #528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec uses
eq
to test for equality of complex numbers. However, the real and imaginary parts areFloat64
, hence there might be numerical issues. Instead, thebe_close
expectation should be used.Using
eq
would require theComplex
class to be modified (e.g. by overloading==
to be slightly imprecise). But this would somehow hard-code the precision ofComplex
, which would not be a good idea ifComplex
was a "production" implementation. Although it is only an exercise, it should not encourage "bad style" like this.