TResource.Delete() method change request. #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added result to TResource.Delete() method. API's are free to return it. Mine does.
* Indy delete method works fine. No need to hack it. * This patch fixes situation when HTTP errors from Indy don't trigger TRestClient.OnError.
Added "@produces" for Delete method. This fixes fail of "DeleteJsonObject" and "RemovePerson" unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @fabriciocolombo and team. Thank you for your work. I'm Igor and I'm a Delphi dev. Currently I'm working on API integration which returns content on DELETE method.
This PR:
Because I'm assuming absense of "@produces" on DELETE methods in controllers is a bad server side design. It should not be hacked on client side as we did.
Please consider PR #135. It fixes java-rest-server compilation for JDK 1.8.