Remove hardcoded versions from device_name_mapping.py and resolve device name in platform classes. #502
Conversation
…ice name in platform classes. Summary: Update platform logic to get names by the platform model without any versions postfixed. This will resolve issues with devices losing their nametags when upgrades occur. Reviewed By: axitkhurana Differential Revision: D36747276 fbshipit-source-id: 24e73efd8f945052ab2181d21ee85a087f420fec
|
This pull request was exported from Phabricator. Differential Revision: D36747276 |
|
Hi @MarkAndersonIX! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Summary: Update platform logic to get names by the platform model without any versions postfixed. This will resolve issues with devices losing their nametags when upgrades occur.
Reviewed By: axitkhurana
Differential Revision: D36747276