Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make batch request name optional #174

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hskrishna29
Copy link

@hskrishna29 hskrishna29 commented Oct 9, 2020

  1. The name parameter for the batch was always being set, although it's not mandatory on the facebook api
  2. There seems to be an issue with the batch request for POST. The name of the batch request ends up getting appended to the actual body of the request, and this caused the entity name to be set as the batch request name on the api
    eg.
    method: POST,
    body: "name=adname..."
    name: "req-name"

the name of the batch is getting appended to the body like below
body: "name=req-name&method=POST&name=adname"
this is causing the ad name that was published to have it's name as req-name instead of ad name.
Removed the else clause that appends the keyvals of the request object to the body field. I'm not sure if that's required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants