fix windows folly build (#2319)

Summary:
fix windows folly build
 * fmt requires unicode, add /utf-8 msvc flag
 * Settings.cpp build failed on SingletonRelaxedCounter, which needed Base::LocalLifetime as MSVC was ignoring the using typename and failing to build
 * MSVC can't handle the parameter to RegexMatchCache::is_span_compatible,  extract out the check that needs E to into the
std::enable_if_t
 * Disable tests that don't compile for windows for now. I see yfeldblum is working on fixing these in T205181491

Pull Request resolved: #2319

Test Plan:
local build with: `python ./build/fbcode_builder/getdeps.py build --src-dir=. folly`

before, [broken](https://github.com/facebook/folly/actions/runs/11402111839/job/31726415001#step:42:629)
```
Z:\installed\fmt--08ZeFppBnK_Qz90kx-Yjd0crzRfSn6gIcQEVrX89l4\include\fmt\base.h(458): error C2338: Unicode support requires compiling with /utf-8
[2/842] Building CXX object CMakeFiles\folly_base.dir\folly\Conv.cpp.obj
```

then...
```
C:\Users\alex\local\folly\folly/container/RegexMatchCache.h(434): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'folly::detail::fallback_span::span<const size_t,18446744073709551615>'
C:\Users\alex\local\folly\folly/container/RegexMatchCache.h(434): note: No constructor could take the source type, or constructor overload resolution was ambiguous
ninja: build stopped: subcommand failed.
Command '['Y:\\build\\folly\\succeed.bat', '&&', 'Y:\\installed\\cmake-_qm1f2PWnzobdL5bp69h3vWFzt0Lbzikp_cDemrJG0U\\bin\\cmake.exe', '--build', 'Y:\\build\\folly', '--target', 'install', '--config', 'RelWithDebInfo', '-j', '32']' returned non-zero exit status 1.
!! Failed`
```

And finally, working.

**internal windows CI**

Before, [build broken](https://www.internalfb.com/sandcastle/workflow/4503599644332087)

After, now it builds green:
```
$ ./opensource/fbcode_builder/getdeps.py sandcastle folly --os-type windows
Mon 21 Oct 00:31:37 PDT 2024
[1/3] Getting the commit data from hg...
[2/3] Bundling and reading phabricator diffs...
[3/3] Starting Sandcastle jobs...
success the following Sandcastle job(s) were started:
```
https://www.internalfb.com/intern/sandcastle/job/18014400016957352/ - oss-folly-windows-getdeps for e822ec118bd9

Reviewed By: dtolnay

Differential Revision: D64604194

Pulled By: ahornby

fbshipit-source-id: ba6851110d007d736e39afc846d87bfc83b9f3f7

CMake/FollyCompilerMSVC.cmake

@@ -120,6 +120,7 @@ function(apply_folly_compile_options_to_target THETARGET)
 
       /permissive- # Be mean, don't allow bad non-standard stuff (C++/CLI, __declspec, etc. are all left intact).
       /std:${MSVC_LANGUAGE_VERSION} # Build in the requested version of C++
+      /utf-8 # fmt needs unicode support, which requires compiling with /utf-8
 
     PRIVATE
       /bigobj # Support objects with > 65k sections. Needed due to templates.

CMakeLists.txt

@@ -649,13 +649,17 @@ if (BUILD_TESTS OR BUILD_BENCHMARKS)
     DIRECTORY algorithm/simd/detail/test/
       TEST algorithm_simd_detail_simd_any_of_test SOURCES SimdAnyOfTest.cpp
       TEST algorithm_simd_detail_simd_for_each_test SOURCES SimdForEachTest.cpp
-      TEST algorithm_simd_detail_simd_traits_test SOURCES TraitsTest.cpp
+      # Needs C++20 on MSVC
+      TEST algorithm_simd_detail_simd_traits_test WINDOWS_DISABLED
+        SOURCES TraitsTest.cpp
       TEST algorithm_simd_detail_unroll_utils_test SOURCES UnrollUtilsTest.cpp
 
     DIRECTORY algorithm/simd/test/
       TEST algorithm_simd_contains_test SOURCES ContainsTest.cpp
       TEST algorithm_simd_find_fixed_test SOURCES FindFixedTest.cpp
-      TEST algorithm_simd_movemask_test SOURCES MovemaskTest.cpp
+      # needs C++20 on MSVC
+      TEST algorithm_simd_movemask_test WINDOWS_DISABLED
+        SOURCES MovemaskTest.cpp
 
     DIRECTORY chrono/test/
       TEST chrono_conv_test WINDOWS_DISABLED
@@ -882,7 +886,9 @@ if (BUILD_TESTS OR BUILD_BENCHMARKS)
 
     DIRECTORY hash/test/
       BENCHMARK hash_checksum_benchmark SOURCES ChecksumBenchmark.cpp
-      TEST hash_checksum_test SOURCES ChecksumTest.cpp
+      # builds, but tests fail on MSVC cmake build
+      TEST hash_checksum_test WINDOWS_DISABLED
+        SOURCES ChecksumTest.cpp
       TEST hash_farm_hash_test SOURCES FarmHashTest.cpp
       BENCHMARK hash_hash_benchmark WINDOWS_DISABLED
         SOURCES HashBenchmark.cpp
@@ -963,7 +969,9 @@ if (BUILD_TESTS OR BUILD_BENCHMARKS)
       TEST lang_aligned_test SOURCES AlignedTest.cpp
       TEST lang_badge_test SOURCES BadgeTest.cpp
       TEST lang_bits_class_test SOURCES BitsClassTest.cpp
-      TEST lang_bits_test SOURCES BitsTest.cpp
+      # Needs C++20 on Windows
+      TEST lang_bits_test WINDOWS_DISABLED
+        SOURCES BitsTest.cpp
       TEST lang_c_string_test SOURCES CStringTest.cpp
       TEST lang_cast_test SOURCES CastTest.cpp
       TEST lang_checked_math_test SOURCES CheckedMathTest.cpp
@@ -1063,15 +1071,19 @@ if (BUILD_TESTS OR BUILD_BENCHMARKS)
       TEST atomic_unordered_map_test SOURCES AtomicUnorderedMapTest.cpp
       TEST base64_test SOURCES base64_test.cpp
       TEST buffered_atomic_test SOURCES BufferedAtomicTest.cpp
-      TEST cancellation_token_test SOURCES CancellationTokenTest.cpp
+      TEST cancellation_token_test WINDOWS_DISABLED
+        SOURCES CancellationTokenTest.cpp
       TEST chrono_test SOURCES ChronoTest.cpp
       TEST clock_gettime_wrappers_test SOURCES ClockGettimeWrappersTest.cpp
       TEST concurrent_bit_set_test SOURCES ConcurrentBitSetTest.cpp
       BENCHMARK concurrent_skip_list_benchmark
         SOURCES ConcurrentSkipListBenchmark.cpp
       TEST concurrent_skip_list_test SOURCES ConcurrentSkipListTest.cpp
-      TEST constexpr_math_test SOURCES ConstexprMathTest.cpp
-      TEST conv_test SOURCES ConvTest.cpp
+      # Builds but fails test on constexpr_exp_floating std::exp(471.L)
+      TEST constexpr_math_test WINDOWS_DISABLED
+        SOURCES ConstexprMathTest.cpp
+      TEST conv_test WINDOWS_DISABLED
+        SOURCES ConvTest.cpp
       TEST cpu_id_test SOURCES CpuIdTest.cpp
       TEST demangle_test SOURCES DemangleTest.cpp
       TEST deterministic_schedule_test SOURCES DeterministicScheduleTest.cpp
@@ -1145,7 +1157,9 @@ if (BUILD_TESTS OR BUILD_BENCHMARKS)
       TEST range_test SOURCES RangeTest.cpp
       TEST replaceable_test WINDOWS_DISABLED SOURCES ReplaceableTest.cpp
       TEST scope_guard_test WINDOWS_DISABLED SOURCES ScopeGuardTest.cpp
-      TEST sdt_test SOURCES SdtTest.cpp
+      # Needs ElfFile
+      TEST sdt_test WINDOWS_DISABLED
+        SOURCES SdtTest.cpp
       # Heavily dependent on drand and srand48
       #TEST shared_mutex_test SOURCES SharedMutexTest.cpp
       # SingletonTest requires Subprocess
@@ -1177,7 +1191,9 @@ if (BUILD_TESTS OR BUILD_BENCHMARKS)
       BENCHMARK uri_benchmark SOURCES UriBenchmark.cpp
       TEST uri_test SOURCES UriTest.cpp
       TEST utf8_string_test SOURCES UTF8StringTest.cpp
-      TEST utility_test SOURCES UtilityTest.cpp
+      # Needs C++20 on MSVC
+      TEST utility_test WINDOWS_DISABLED
+        SOURCES UtilityTest.cpp
       TEST varint_test SOURCES VarintTest.cpp
 
     DIRECTORY testing/test/

folly/concurrency/SingletonRelaxedCounter.h

@@ -231,8 +231,10 @@ class SingletonRelaxedCounter
   using typename Base::LocalLifetime;
   using typename Base::Signed;
 
-  struct MonoLocalLifetime : LocalLifetime {
-    ~MonoLocalLifetime() noexcept(false) { LocalLifetime::destroy(global); }
+  struct MonoLocalLifetime : Base::LocalLifetime {
+    ~MonoLocalLifetime() noexcept(false) {
+      Base::LocalLifetime::destroy(global);
+    }
   };
 
   //  It is an invariant that in a single call to mutate which calls mutate_slow

folly/container/RegexMatchCache.h

@@ -391,15 +391,14 @@ class RegexMatchCacheKey {
   static data_type init(std::string_view regex) noexcept;
 
   template <typename T, typename V = std::remove_cv_t<T>>
-  static constexpr bool is_span_compatible(size_t const e) noexcept {
+  static constexpr bool is_span_compatible() noexcept {
     return //
         !std::is_volatile_v<T> && //
         std::is_integral_v<V> && //
         std::is_unsigned_v<V> && //
         !std::is_same_v<bool, V> && //
         !std::is_same_v<char, V> && //
-        alignof(V) <= data_align &&
-        (e == data_size / sizeof(V) || e == dynamic_extent);
+        alignof(V) <= data_align;
   }
 
  public:
@@ -409,7 +408,10 @@ class RegexMatchCacheKey {
   template <
       typename T,
       std::size_t E,
-      std::enable_if_t<is_span_compatible<T>(E), int> = 0>
+      std::enable_if_t<
+          is_span_compatible<T>() &&
+              (E == data_size / sizeof(T) || E == dynamic_extent),
+          int> = 0>
   explicit operator span<T const, E>() const noexcept {
     return {reinterpret_cast<T const*>(data_.data()), E};
   }