Mark header deprecated

Summary: As titled. Reviewed By: mahmednabil109 Differential Revision: D68427785 fbshipit-source-id: 6768d2e7545ca1117b0f60da4daac849063ec63c
facebook · Jan 23, 2025 · 55a3b4c · 55a3b4c
1 parent dbfa22a
commit 55a3b4c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/third-party/thrift/src/thrift/lib/go/thrift/client.go b/third-party/thrift/src/thrift/lib/go/thrift/client.go
@@ -48,6 +48,7 @@ func WithProtocolID(id types.ProtocolID) ClientOption {
 }
 
 // WithHeader sets the transport to Header, protocol Header is implied here.
+// Deprecated: use WithUpgradeToRocket() instead.
 func WithHeader() ClientOption {
 	return func(opts *clientOptions) {
 		opts.transport = TransportIDHeader

diff --git a/third-party/thrift/src/thrift/lib/go/thrift/transport.go b/third-party/thrift/src/thrift/lib/go/thrift/transport.go
@@ -29,6 +29,7 @@ const (
 	// TransportIDUnknown is the default value for TransportID
 	TransportIDUnknown TransportID = 0
 	// TransportIDHeader is the header transport
+	// Deprecated: use TransportIDUpgradeToRocket instead.
 	TransportIDHeader TransportID = 1
 	// TransportIDRocket is the Rocket transport
 	TransportIDRocket TransportID = 2