Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide less cryptic error for missing systemlib sections #9566

Closed

Conversation

mszabo-wikia
Copy link
Contributor

If a new extension systemlib isn't wired up with the build system, its unit emitters and decls won't be embedded in the HHVM binary, causing a cryptic crash when trying to run Hack code ("Invalid varint value: too few bytes."). One then has to fire up a debugger to determine what systemlib is missing.

Instead, raise a more informative error if a specific systemlib was not found in the binary.

Split from #9564.

If a new extension systemlib isn't wired up with the build system, its
unit emitters and decls won't be embedded in the HHVM binary, causing
a cryptic crash when trying to run Hack code ("Invalid varint value: too
few bytes."). One then has to fire up a debugger to determine what systemlib is
missing.

Instead, raise a more informative error if a specific systemlib was not
found in the binary.
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.)

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 2412906.

@mszabo-wikia mszabo-wikia deleted the systemlib-compile-feedback branch January 7, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants