Generate config headers from configs.specification #9587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.) |
Wilfred
requested changes
Jan 28, 2025
Since a41bcb1, configuration headers and sources are generated using a Rust tool rather than being hardcoded. Implement the CMake logic necessary to compile the tool and generate these sources. Use a Python script to extract config section names from the specification file instead of hardcoding them into CMake build files to reduce the chance of the CMake build getting out of a sync. A followup PR will handle connecting the hackc_options target to the Rust libraries that depend on it.
mszabo-wikia
force-pushed
the
generate-config-headers
branch
from
426a193 to
d3aa679
Compare
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
|
Done with |
|
This pull request has been merged in ca8fbd4. |
|
@Wilfred It looks like the Cargo.toml manifest got lost after the merge—AFAIK this might be because they're generated automatically from the internal buck2 buildfiles. Would it be possible to do that to allow OSS to compile the config generation tool? Let me know if this requires any restructuring on the CMake side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a41bcb1, configuration headers and sources are generated using a Rust tool rather than being hardcoded. Implement the CMake logic necessary to compile the tool and generate these sources. Use a Python script to extract config section names from the specification file instead of hardcoding them into CMake build files to reduce the chance of the CMake build getting out of a sync.
A followup PR will handle connecting the hackc_options target to the Rust libraries that depend on it.