Skip to content

Commit

Permalink
Workaround gcc11 bug that occurs when building AckHandlersTest
Browse files Browse the repository at this point in the history
Summary:
This fixes a compiler bug that is hit when building AckHandlersTest.cpp using gcc11.

This was reported in #331 and started happening consistently when the Github CI build was updated to use Ubuntu 22.04.

Reviewed By: chadaustin, sharmafb

Differential Revision: D57506683

fbshipit-source-id: a156a9ba7641f395ea9da01ec084fdccb3d6a88b
  • Loading branch information
jbeshay authored and facebook-github-bot committed May 17, 2024
1 parent 004ba6f commit 631a222
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions quic/state/test/AckHandlersTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1090,8 +1090,8 @@ TEST_P(AckHandlersTest, TestAckMultipleSequentialBlocksLoss) {
conn.outstandings.packets.begin(),
conn.outstandings.packets.end(),
[](auto& op) {
return op.packet.header.getPacketSequenceNum() == 15 ||
op.packet.header.getPacketSequenceNum() == 16;
auto seqno = op.packet.header.getPacketSequenceNum();
return seqno == 15 || seqno == 16;
});
EXPECT_TRUE(itr != conn.outstandings.packets.end());
EXPECT_TRUE(itr->declaredLost);
Expand All @@ -1114,8 +1114,8 @@ TEST_P(AckHandlersTest, TestAckMultipleSequentialBlocksLoss) {
conn.outstandings.packets.begin(),
conn.outstandings.packets.end(),
[](auto& op) {
return op.packet.header.getPacketSequenceNum() == 15 ||
op.packet.header.getPacketSequenceNum() == 16;
auto seqno = op.packet.header.getPacketSequenceNum();
return seqno == 15 || seqno == 16;
});
EXPECT_TRUE(itr == conn.outstandings.packets.end());

Expand Down

0 comments on commit 631a222

Please sign in to comment.