Skip to content

Commit

Permalink
Use a factory to create ClientHandshake (#59)
Browse files Browse the repository at this point in the history
Summary:
This will allow to be able to create different kind of handshake going forward.
Pull Request resolved: facebook/mvfst#59

Reviewed By: siyengar

Differential Revision: D18088574

Pulled By: mjoras

fbshipit-source-id: 0732bb63a9e243fef77cdaf4f76e711fcb09ecdc
  • Loading branch information
deadalnix authored and facebook-github-bot committed Nov 5, 2019
1 parent e81bb68 commit 2136700
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion proxygen/httpserver/samples/hq/HQClient.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ void HQClient::initializeQuicClient() {

client->setPacingTimer(pacingTimer_);
client->setHostname(params_.host);
client->setFizzClientContext(createFizzClientContext(params_));
client->setFizzClientQuicHandshakeContext(createFizzClientContext(params_));
// This is only for testing, this should not be use in prod
client->setCertificateVerifier(
std::make_unique<
Expand Down
2 changes: 1 addition & 1 deletion proxygen/lib/http/HQConnector.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ void HQConnector::connect(
auto sock = std::make_unique<folly::AsyncUDPSocket>(eventBase);
auto quicClient =
quic::QuicClientTransport::newClient(eventBase, std::move(sock));
quicClient->setFizzClientContext(fizzContext);
quicClient->setFizzClientQuicHandshakeContext(fizzContext);
quicClient->setCertificateVerifier(std::move(verifier));
quicClient->setHostname(sni.value_or(connectAddr.getAddressStr()));
quicClient->addNewPeerAddress(connectAddr);
Expand Down

0 comments on commit 2136700

Please sign in to comment.