[Android] Add DisplayP3 background and border support to View

[ryanlntn]

Summary:

This builds on previous PRs for the wide gamut color RFC and extends Android views with support for DisplayP3 backgrounds and borders.

Changelog:

[ANDROID] [ADDED] - Add DisplayP3 background and border support to View

Test Plan:

1. Pull changes from these previous PRs:
   [JS] Add support for CSS4 color() functions #42831
   [Android] Update ColorPropConverterto support color function values #43031
   [Android] Add isWideColorGamutEnabled to ReactActivityDelegate #43036
2. Follow the test steps for each PR
3. Pull these changes and build RNTester for Android: cd packages/rn-tester && yarn android
4. Navigate to ViewExample and observe DisplayP3 background/borders

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[cortinico]

Can we instead use something like a ColorDrawable here or avoid using reflection if possible

[ryanlntn]

@cortinico I tried making ColorDrawable work but I don't think I can make it work with long colors. Instead I think we can just check if the view is an instance of ReactViewGroup (Is this always true?) and that seems to work.

[cortinico]

we can just check if the view is an instance of ReactViewGroup (Is this always true?)

I don't think it's always true sadly

[cortinico]

Ideally we'd want new classes to be in Kotlin at this stage

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[cipolleschi]

Hi @ryanlntn, using ReactViewGroups creates a circular dependencies in the internal CI, we have some difference in how modules are structured internally.

Can you refresh my memory and remind me why you need to cast the view to ReactViewGroup? Can't we use the same approach we use below for regular views?

[ryanlntn]

@cipolleschi Since I updated this to remove the use of reflection we need to cast to a type that supports setBackgroundColor(long color) or it won't compile. Regular views only support setBackgroundColor(int color). Would it be better to create a new subclass of View to extend for T?

[cipolleschi]

@ryanlntn We can't do in this way, unfortunately. Due to the circular dependencies, it will not work internally. And a subclass will give us no guarantees that it will be instantiated properly. I think that we need an interface.

The best way to move forward is probably:

1. in the uimanager folder, let's create an Interface:

public interface ReactWideGamutView extends View {
  public void setBackgroundColor(long color);
  // other methods required by wide gamut
}

2. Make the ReactViewGroup implement the ReactWideGamutView interface
3. Replace the casting to ReactViewGroup with a check like:

if (view instanceof ReactWideGamutView) {
      ((ReactWideGamutView) view).setBackgroundColor(backgroundColor);

In this way, we don't have the circular dependency, because the ReactWideGamutView will live in the same package as ReactUIManager and we can safely cast the view to the right interface and avoid any subclass.
Also, all future subclasses of ReactViewGroup will benefit from implementing the same interface out of the box.

We should check whether there are other React componentes that we need to make them implement the same interface.... 🤔

[cipolleschi]

This is also the same approach used for uimanager.ReactZIndexedViewGroup: as you can see this interface leaves in the uimanager package.

What do you think?

[ryanlntn]

That makes sense to me. I'll get it updated. 😄

[ryanlntn]

Updated!

We should check whether there are other React componentes that we need to make them implement the same interface....

AFAIK this isn't the case yet. Implementing this in ReactViewGroup is all I need to get wide gamut backgrounds working for View.

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.