You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for color longs to HostPlatformColor per the wide gamut color RFC.
Changelog:
[ANDROID] [ADDED] - Update HostPlatformColor to support color longs
Test Plan:
This requires changes from #43030 to build and will only break text color until those components are updated to support color long values as well. Will update with a link to that PR soon.
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
labels
Feb 22, 2024
Could we document what the magic numbers are doing? Maybe pull them out into constants?
@NickGerleman I pulled out the color space and component ratios definitions into constants. Should I do similar with the bit masks/shifts? I can't decide what's more readable.
CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Shared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.StaleThere has been a lack of activity on this issue and it may be closed soon.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
facebook-github-bot
added
CLA Signed
ryanlntn
force-pushed
the
feat/android-host-platform-color-longs
branch
2 times, most recently
from
react-native-bot
added
the
Stale
Summary:
This adds support for color longs to HostPlatformColor per the wide gamut color RFC.
Changelog:
[ANDROID] [ADDED] - Update HostPlatformColor to support color longs
Test Plan:
This requires changes from #43030 to build and will only break text color until those components are updated to support color long values as well. Will update with a link to that PR soon.