fix : Handle absolute paths for custom inject source #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
nonzzz
reviewed
Dec 21, 2023
| runtimeInjection.startsWith('./') || | ||
| runtimeInjection.startsWith('../') | ||
| ) { | ||
| const absolutePath = path.join(rootDir, runtimeInjection); |
There was a problem hiding this comment.
I think should add a normalize function to remove platform differences.
There was a problem hiding this comment.
you mean path.normalize(path.join()) ?
There was a problem hiding this comment.
* Fix: Validate options passed into the Babel plugin * Add full validation for options with good errors
* Docs: Fix code example typo (facebook#290) * Handle `keyframe` within `defineVars` * Add test * Format * Fix grammar * Update stylex-validation-define-vars-test.js --------- Co-authored-by: k14lb3 <[email protected]>
* Add eslint-plugin package * Add initial test suite * Improve CSS handling and tests * Address some of the comments * Add babel scripts for jsx, flow and ts * Add package diff * Add snapshots and fix nits * Fix rename bug * Add esbuild example app * Fix incorrect loaders * Update package-lock.json * Remove unnecessary file * Fix some nits in example * Add additional style to text fixture * Remove ext from import in example * Address some of the comments * Update package-lock.json * Add missing function call and snapshot * Remove comment * Pluralize function name * Add types * Fix build script * Add docs * Fix tabulation * Retake snapshots * Format prettier * Add more missing types * Run formatter * Fix formatting * Lock dependency and fix import * Disable unused key * Add docs * Update package-lock.json * Update package-lock.json * Add snapshots * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
Handle absolute paths for custom inject source
checks for absolute and relative path
Linked PR/Issues
Fixes #211
Additional Context
i will move forward with
importSourcesonce this gets approvedPre-flight checklist
Contribution Guidelines