Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix readCache to use custom cache path when set #851

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: fix readCache to use custom cache path when set #851

wants to merge 3 commits into from

Conversation

mellyeliu
Copy link
Member

@mellyeliu mellyeliu commented Jan 13, 2025 •
edited
Loading

What changed / motivation ?

Oversight in #792 where readCache is still reading from default cache path

Testing

Added more comprehensive testing, previously we were just ensuring the correct cache files were written, not checking the read functionality

Pre-flight checklist

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 13, 2025
@mellyeliu mellyeliu changed the base branch from main to cli-cache-m January 13, 2025 01:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

@stylexjs/[email protected] size:compare
./size-compare.js /tmp/tmp.EyYvPB5tkA /tmp/tmp.5tvcwbabe2

Results Base Patch Ratio
stylex/lib/stylex.js
· compressed 729 729 1.00
· minified 2,541 2,541 1.00
stylex/lib/StyleXSheet.js
· compressed 1,266 1,266 1.00
· minified 3,776 3,776 1.00
rollup-example/.build/bundle.js
· compressed 567,110 567,110 1.00
· minified 10,232,512 10,232,512 1.00
rollup-example/.build/stylex.css
· compressed 100,626 100,626 1.00
· minified 757,176 757,176 1.00

Base automatically changed from cli-cache-m to main January 13, 2025 03:41
nmn
nmn requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@nmn nmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit and also failing signal.

packages/cli/src/cache.js Outdated Show resolved Hide resolved
@mellyeliu mellyeliu requested a review from nmn January 13, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmn nmn Awaiting requested review from nmn

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mellyeliu @nmn @facebook-github-bot