Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ci tests #4243

Merged
merged 8 commits into from
Jan 16, 2025
Merged

fix ci tests #4243

merged 8 commits into from
Jan 16, 2025

Conversation

Cyan4973
Copy link
Contributor

@Cyan4973 Cyan4973 commented Jan 15, 2025

Some Github CI tests have started failing recently, as a consequence of updating the underlying ubuntu image.
Try to fix the created issues one by one in this PR, to end up on an all-green signal.

  • clang-pgo : this test was tied to clang-14, which is no longer supported in latest ubuntu image. Use the "generic" clang instead, requiring installation of the companion profiler tool.
  • meson-linux, cmake-build-and-check, make-external-compressor : require explicit installation of liblzma-dev package (no longer provided by default in the image)

missing the liblzma package
missing the liblzma-dev package
@Cyan4973
Copy link
Contributor Author

Cyan4973 commented Jan 16, 2025

The zlib-wrapper error can also be reproduced locally, so it's not related to Github Actions VMs.
It's curious it started failing at the same time.
Maybe the library version changed, and modified a behavior ?

No clear explanation for the time being: the file example.c fails here .
It's a direct correspondence from a zlib test file.

edit : indeed, in more recent versions of zlib, the test changed, and now expects a different error code (Z_STREAM_END instead of Z_DATA_ERROR). to be fixed.

new versions of the library generate a different error code
@Cyan4973 Cyan4973 marked this pull request as ready for review January 16, 2025 00:36
@Cyan4973
Copy link
Contributor Author

All tests fixed, CI signal green.

I'm going to merge this, so that we can rebase ongoing PRs on top of it, and observe a clean green signal before merge.

@Cyan4973 Cyan4973 merged commit 7227707 into dev Jan 16, 2025
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants