-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: quote include directory for resource compiler #4269
Conversation
Hi @luau-project! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
I suspect it would be good to have a CI test that reproduces this issue, |
Hello @Cyan4973 . I can write a GitHub CI job to test it. Since I don't know the inner details of zstd CI testing, I would need to know which workflow (.yaml file) I should include a test job. |
In The idea would be to either piggy-back on this test to add a "directory with space" condition, |
I've got a working CI job to build / test cmake-source-directory-with-spaces:
runs-on: ${{ matrix.os }}
strategy:
matrix:
include:
- os: ubuntu-latest
generator: "Unix Makefiles"
- os: windows-latest
generator: "NMake Makefiles"
- os: macos-latest
generator: "Unix Makefiles"
env:
SRC_DIR: "source directory with spaces"
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # tag=v4.1.1
with:
path: "${{ env.SRC_DIR }}"
- uses: ilammy/msvc-dev-cmd@v1
if: ${{ matrix.generator == 'NMake Makefiles' }}
- name: cmake build and test source directory with spaces
run: |
cmake -S "${{ env.SRC_DIR }}/build/cmake" -B build -DBUILD_TESTING=ON -G "${{ matrix.generator }}" -DCMAKE_BUILD_TYPE=Release --install-prefix "${{ runner.temp }}/install"
cmake --build build --config Release
ctest --test-dir build -C Release
cmake --install build --config Release Note These runs are taking 21m to complete. Should I keep the testing part or remove I'm awaiting your review and signal to push the CI job to the file |
21 mn seems a bit much for a build test. For comparison sake, the current |
Also, just minor point,
|
Yes, they were running in parallel. I removed the line |
oh, I'm not that skilled on git, specially with rebase. I probably would mess up the history. I can either push the job (without the testing line) to the proper workflow as a new commit, or you can manipulate and edit the git history, since you are allowed to edit as a maintainer. |
That works, I can take care of this. |
4fa306e
to
868b6de
Compare
868b6de
to
6cd4204
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's interesting to note that macos
seems to have been immune to this issue,
but Windows definitely wasn't.
Description
Fixes #4268
Test