Add Functions to Read and Write dcz Headers
#4272
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They say "never roll your own crypto" but... they hate us cuz they ain't us. This commit adds a very simple implementation of the SHA-256 hashing algorithm. This implementation is constructed in part by reference to the specification[0] and in part by looking at how some other single-file implementations work. This commit also adds a little test program that validates that our implementation passes all of the NIST test vectors. So it's probably correct! [0] https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.180-4.pdf
I guess the kernel binding's version of `zstd_deps.h` will need to be updated to add a `ZSTD_memcmp()` define.
felixhandte
force-pushed
the
dcz-sha-skippable-frame
branch
from
7190186 to
eefd670
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to Zstd for handling the header used by the
dczHTTP Content-Encoding, described indraft-ietf-httpbis-compression-dictionary.To-Do: