Add x86_64 support #19

leeight · 2016-10-07T01:36:02Z

ide

Have some questions, it's not clear to me just looking at the code what the answers are.

ide · 2016-10-10T08:01:23Z

jsc/BUCK

-# version to be 1 so that StdLibExtra.h doesn't try to declare
-# is_trivially_destructible
-# Except from this single place JSC code doesn't check for 4.8.1 anywhere else
-WTF_EXPORTED_PREPROCESSOR_FLAGS.extend([


Why is this OK to remove now?

gcc 4.9 is ok, gcc 4.8 need that patch.

ide · 2016-10-10T08:01:40Z

.buckconfig

+    ndk_version = r10e
+    cpu_abis = armv7, arm64, x86, x86_64
+    gcc_version = 4.9
+    app_platform = android-21


Should this be 16 to support Android 4.1?

I tried different platforms, it looks like only android-21 can work, but i can figure out the reason.

OK thanks, the JSC AAR file needs to work with API 16 since React Native supports API 16.

Probably because android-21 was the first platform that contained the x86_64 and arm64 ndk ABI.

ide · 2016-10-10T08:01:57Z

jsc/BUCK

@@ -165,6 +152,7 @@ cxx_library(
  supported_platforms_regex = SUPPORTED_PLATFORMS,
  header_namespace = '',
  headers = subdir_glob([
+    ('WTF', '*.h'),
    ('WTF/wtf', '*.h'),


Why is this needed?

encounter an error, missing "config.h"

jsc/WTF/wtf/unicode/CollatorDefault.cpp:29:20: fatal error: config.h: No such file or directory #include "config.h" ^ compilation terminated. jsc/WTF/wtf/unicode/CollatorDefault.cpp:29:20: fatal error: config.h: No such file or directory #include "config.h" ^ compilation terminated. jsc/WTF/wtf/unicode/CollatorDefault.cpp:29:20: fatal error: config.h: No such file or directory #include "config.h" ^ compilation terminated. jsc/WTF/wtf/unicode/CollatorDefault.cpp:29:20: fatal error: config.h: No such file or directory #include "config.h" ^ compilation terminated. BUILD FAILED: //jsc:wtfcollation#android-x86,compile-pic-CollatorDefault.cpp.oe467649f failed with exit code 1: c++ piped_preprocess_and_compile

leeight · 2016-10-10T10:15:45Z

This is the build output, but this PR depends on facebook/buck#921


   Date      Time    Attr         Size   Compressed  Name
------------------- ----- ------------ ------------  ------------------------
1985-02-01 00:00:00 .....          224          152  AndroidManifest.xml
1985-02-01 00:00:00 .....            0            2  R.txt
1985-02-01 00:00:00 D....            0            0  assets
1985-02-01 00:00:00 .....          293          136  classes.jar
1985-02-01 00:00:00 D....            0            0  jni
1985-02-01 00:00:00 D....            0            0  jni/arm64-v8a
1985-02-01 00:00:00 .....      1439272       548379  jni/arm64-v8a/libicu_common.so
1985-02-01 00:00:00 .....      3185640      1169618  jni/arm64-v8a/libjsc.so
1985-02-01 00:00:00 D....            0            0  jni/armeabi-v7a
1985-02-01 00:00:00 .....       931204       440769  jni/armeabi-v7a/libicu_common.so
1985-02-01 00:00:00 .....      1898652       938992  jni/armeabi-v7a/libjsc.so
1985-02-01 00:00:00 D....            0            0  jni/x86
1985-02-01 00:00:00 .....      1414424       580893  jni/x86/libicu_common.so
1985-02-01 00:00:00 .....      5081248      1828951  jni/x86/libjsc.so
1985-02-01 00:00:00 D....            0            0  jni/x86_64
1985-02-01 00:00:00 .....      1374064       542868  jni/x86_64/libicu_common.so
1985-02-01 00:00:00 .....      4849408      1749414  jni/x86_64/libjsc.so
1985-02-01 00:00:00 D....            0            0  res
------------------- ----- ------------ ------------  ------------------------
1985-02-01 00:00:00           20174429      7800174  11 files, 7 folders

LegNeato · 2017-02-01T03:35:21Z

Is this ever going to get cleaned up and landed?

LegNeato · 2017-02-01T03:35:35Z

(buck support for 64bit on Android has been in for months)

ide · 2017-02-02T23:39:08Z

This looks good to me. I believe it's fine to bump the target Android version, which is separate from the minimum Android version, so we'll still maintain compatibility with 4.x.

@mkonicek Could you merge this?

franzks-zz · 2017-06-06T07:04:30Z

I'm trying to understand why React Native doesn't support arm64, and from reading the discussion on the RN issues post it seems this project is one of the dependencies, so until android-jsc officially supports arm64 support I guess RN won't be able to.

What else is blocking this PR from being merged?

bootstraponline · 2017-08-11T18:40:58Z

It'd be great to see this PR merged. The build scripts are broken on master.

govi · 2017-12-04T10:00:32Z

If there is any appetite to get this merged, I can raise a PR. The URL to download jsc sources is now broken, but we can still checkout the svn repo and get the same revision.

If there are other problems, it'd help us. We are seeing massive drop in performance for some use cases. If we are unable to support 64-bit sooner, it might make react-native a no-go for us.

newyankeecodeshop · 2017-12-04T14:05:29Z

@govi Have you tried the JavaScriptCore from this project? https://github.com/SoftwareMansion/jsc-android-buildscripts
We have been using it in a couple of RN apps on Android, and it's great having a modern, ES2015 JavaScript runtime.

govi · 2018-01-03T18:44:10Z

@newyankeecodeshop well, expo seemed to have rolled it back in their last release, due to some crashes in date functions. Prolly irrelevant to this ticket, but what is your experience with the new-jsc?

newyankeecodeshop · 2018-01-03T20:04:37Z

@govi We've been using it for several months on a new app running on Android 4.2-5.1 and haven't had any issues. We don't use the date toLocaleString function that caused issues. It's been great having the full runtime APIs similar to iOS 10, which is the iOS version we target.

gengjiawen · 2018-01-17T04:57:58Z

@ide anything we can do to push this foward ?

ide · 2018-01-17T05:49:57Z

@gengjiawen The work was happening in this repo: https://github.com/SoftwareMansion/jsc-android-buildscripts. The one thing that comes to mind is testing the new JSC in a lot of conditions (different types of phones, different JS bundles).

gengjiawen · 2018-01-17T06:12:58Z

But currently android-jsc still use nightly build webkit before 2016-08-26 and have no test. My main concern is that keep javascripcore up to date will give us better performance and better support to modern js features. And also support more cpu will get react native widely adopted.

ide · 2018-01-17T06:18:11Z

Work in this repo appears to have stopped -- the most recent work on JSC for RN Android was on this repo: https://github.com/SoftwareMansion/jsc-android-buildscripts. That's where work for new versions of JSC (ES2015, 64-bit) is happening.

That said, it seems fine to me to merge this PR and I'll talk to someone who works on the FB Open Source team to see if they can help.

gengjiawen · 2018-01-17T06:30:48Z

As far as I know, react native is still use this repo (https://github.com/facebook/react-native/blob/999851a3891b4c6ceffd37fa3a6bdb27c5b6159e/ReactAndroid/build.gradle#L291). And thanks for reaching out.

AustinHunt · 2019-03-08T21:55:39Z

When is this going to be added? Am I missing something?

facebook-github-bot added the CLA Signed label Oct 7, 2016

Add x86_64 support

ee6e7e3

leeight force-pushed the x86_64 branch from 3a2034a to ee6e7e3 Compare October 7, 2016 01:37

This was referenced Oct 7, 2016

[Performance] Investigate performance of the DFG and FLT JITs #7

Open

Support more android abis (arm64, x86_64) #5

Open

facebook-github-bot added the CLA Signed label Oct 7, 2016

leeight mentioned this pull request Oct 9, 2016

Can we support android armeabi #17

Closed

Add arm64

336b3a4

ide reviewed Oct 10, 2016

View reviewed changes

csotiriou mentioned this pull request Jun 8, 2017

Support third-party 64-bit libraries on Android facebook/react-native#2814

Closed

bootstraponline mentioned this pull request Aug 11, 2017

No CI. Does not build on latest NDK/BUCK #23

Open

govi mentioned this pull request Jan 17, 2018

[WIP] Android 64-bit facebook/react-native#17640

Closed

rzsombor mentioned this pull request Apr 13, 2018

Add arm64 x86_64 support #30

Closed

AustinHunt mentioned this pull request Mar 9, 2019

Building out on macOS 10.14.3 -> CMake was unable to find a build program corresponding to "Ninja" react-native-community/jsc-android-buildscripts#90

Open

hey99xx mentioned this pull request Jun 27, 2019

"What do you dislike about React Native?" June 2019 Edition react-native-community/discussions-and-proposals#134

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add x86_64 support #19

Add x86_64 support #19

leeight commented Oct 7, 2016

ide left a comment

ide Oct 10, 2016

leeight Oct 10, 2016

ide Oct 10, 2016

leeight Oct 10, 2016

ide Oct 10, 2016

LegNeato Oct 15, 2016 •

edited

Loading

ide Oct 10, 2016

leeight Oct 10, 2016

leeight Oct 10, 2016

leeight commented Oct 10, 2016

LegNeato commented Feb 1, 2017

LegNeato commented Feb 1, 2017

ide commented Feb 2, 2017

franzks-zz commented Jun 6, 2017

bootstraponline commented Aug 11, 2017

govi commented Dec 4, 2017

newyankeecodeshop commented Dec 4, 2017

govi commented Jan 3, 2018

newyankeecodeshop commented Jan 3, 2018

gengjiawen commented Jan 17, 2018

ide commented Jan 17, 2018

gengjiawen commented Jan 17, 2018 •

edited

Loading

ide commented Jan 17, 2018

gengjiawen commented Jan 17, 2018

AustinHunt commented Mar 8, 2019

Add x86_64 support #19

Are you sure you want to change the base?

Add x86_64 support #19

Conversation

leeight commented Oct 7, 2016

ide left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LegNeato Oct 15, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leeight commented Oct 10, 2016

LegNeato commented Feb 1, 2017

LegNeato commented Feb 1, 2017

ide commented Feb 2, 2017

franzks-zz commented Jun 6, 2017

bootstraponline commented Aug 11, 2017

govi commented Dec 4, 2017

newyankeecodeshop commented Dec 4, 2017

govi commented Jan 3, 2018

newyankeecodeshop commented Jan 3, 2018

gengjiawen commented Jan 17, 2018

ide commented Jan 17, 2018

gengjiawen commented Jan 17, 2018 • edited Loading

ide commented Jan 17, 2018

gengjiawen commented Jan 17, 2018

AustinHunt commented Mar 8, 2019

LegNeato Oct 15, 2016 •

edited

Loading

gengjiawen commented Jan 17, 2018 •

edited

Loading