Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

Commit

Permalink
Fix Android 4.38.0
Browse files Browse the repository at this point in the history
  • Loading branch information
Calvin Mak committed Nov 8, 2018
1 parent 26049f0 commit ff743b2
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions android/src/main/java/com/facebook/reactnative/androidsdk/FBGraphRequestModule.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ private void setConfig(GraphRequest graphRequest, ReadableMap configMap) {
null,
null,
null,
null,
null));
} else {
graphRequest.setAccessToken(AccessToken.getCurrentAccessToken());
Expand Down
2 changes: 1 addition & 1 deletion android/src/main/java/com/facebook/reactnative/androidsdk/FBSDKPackage.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

public class FBSDKPackage implements ReactPackage {

public static final String VERSION_TO_RELEASE = "ReactNative-v0.7.0";
public static final String VERSION_TO_RELEASE = "ReactNative-v0.9.0";

private CallbackManager mCallbackManager;
public FBSDKPackage(CallbackManager callbackManager) {
Expand Down
2 changes: 1 addition & 1 deletion ios/RCTFBSDK/core/RCTFBSDKInitializer.m
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ @implementation RCTFBSDKInitializer
- (instancetype)init
{
if ((self = [super init])) {
[FBSDKSettings setUserAgentSuffix:@"ReactNative-v0.7.0"];
[FBSDKSettings setUserAgentSuffix:@"ReactNative-v0.9.0"];
}
return self;
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-fbsdk",
"version": "0.8.0",
"version": "0.9.0",
"description": "Facebook SDK support for React Native apps.",
"main": "./js/index.js",
"author": {
Expand Down

6 comments on commit ff743b2

@nickfla1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional that this is not available via npm yet?
Thank you.

@lorenc-tomasz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos @codytwinton ?

@rohit75
Copy link

@rohit75 rohit75 commented on ff743b2 Dec 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this version is not available in npm.

@Buthrakaur
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get compilation error when trying to use this version with facebookSdkVersion=4.38.0:

node_modules\react-native-fbsdk\android\src\main\java\com\facebook\reactnative\androidsdk\Utility.java:64: error: no suitable constructor found for AccessToken(String,String,String,List<String>,List<String>,AccessTokenSource,Date,Date)
        return new AccessToken(
               ^
    constructor AccessToken.AccessToken(String,String,String,Collection<String>,Collection<String>,AccessTokenSource,Date,Date,Date) is not applicable
      (actual and formal argument lists differ in length)
    constructor AccessToken.AccessToken(Parcel) is not applicable
      (actual and formal argument lists differ in length)

@dbarner1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here 👆

@n-sviridenko
Copy link

@n-sviridenko n-sviridenko commented on ff743b2 Jun 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question. Should we refer on the commit tag or we can use 0.8.0 w/o being worried of missing something?

Please sign in to comment.