fix: Fix aggregate result error while use gcc11 compile with O2 optim… #12176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
for simplify the test code and test data file, i use only a subset data from #11257 test data, and the data can repeat the problem and verify the fix |
Yuhta
reviewed
Jan 27, 2025
lifulong
force-pushed
the
fix_wrong_result_use_gcc11
branch
from
774e4f4 to
b095f86
Compare
|
@majetideepak can you help review this change? |
Yuhta
approved these changes
Feb 11, 2025
Yuhta
added
the
ready-to-merge
|
@lifulong Can you fix the code format issue ? |
ok , i have fix the code format issue, can you help trigger the check again? |
lifulong
force-pushed
the
fix_wrong_result_use_gcc11
branch
from
b095f86 to
60488d7
Compare
|
@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This was referenced Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11257
I found the wrong result with gcc11 is originated by gcc inline optimize rule by test, use gcc -O1 compile result is ok, use gcc -O2 -fno-inline result is ok, but gcc -O2 result is wrong
three ways can fix this problem in my test:
__attribute__((noinline))before functionaddValuesin source file velox/vector/LazyVector.h at line 121, disable inlineaddValuesfunctionasm volatile("" ::: "memory");before callhook.addValuesat line 267 in source file velox/dwio/common/DecoderUtil.h, disable instruction reordering herevaluesto a tmp array before callhook.addValuesat line 267 in source file velox/dwio/common/DecoderUtil.h, same as logic at line 327 in source file velox/dwio/common/DecoderUtil.has it show above, there is same logic as fix way 3 at line 327 in source file velox/dwio/common/DecoderUtil.h, so i choose this resolution also, and i have add unit test recording to this problem, make sure the problem fixed.
i think this error may cause by gcc inline and instruction reordering, use error variable values while program exec ? for example we update variable a and use it, after inline and code reorder, variable a update after use, i am not sure here, i have read one article introduce same kind problem cause by gcc inline and code reorder lead to register value mis use.