test: Adjust assertion for random skip to be platform/architecture-dependent #12298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 10, 2025 15:39
…ColumnsMutation to be platform/architecture-dependent
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Yuhta
approved these changes
Feb 10, 2025
Yuhta
added
the
ready-to-merge
Yuhta
changed the title
|
Hey @Yuhta , I failed |
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adjust assertion in ReaderTest.projectColumnsMutation based on platform. The assertion for the random skip is assuming it is using
__gnu_cxx::sfmt19937, however if usingstd::mt19937then the result will be different and the unit test will fail due to this.This PR is to fix the issue: #12240