refactor: Setup scripts #12321
refactor: Setup scripts #12321
Conversation
anandamideShakyan
requested review from
assignUser and
majetideepak
as code owners
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
anandamideShakyan
force-pushed
the
shakyan-refactor-setup-scripts
branch
from
449b3a0 to
b5d0ca3
Compare
| @@ -67,7 +67,7 @@ jobs: | |||
| env: | |||
| HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: "TRUE" | |||
| run: | | |||
| source scripts/setup-macos.sh | |||
| scripts/setup-macos.sh | |||
There was a problem hiding this comment.
This will run the full script and not just the functions below. The purpose of this was to get most dependencies from the bundle and not rely on the system installation of the dependencies. You can see the functions below only run a subset.
Please read the comment from @majetideepak in my original PR about this. We need more changes to refactor this build script or we leave the original intent and separate the bundling vs non-bundling between the versions of macOS later.
| source $SCRIPTDIR/setup-helper-functions.sh | ||
| source $SCRIPTDIR/setup-versions.sh | ||
|
|
||
| NPROC=$(getconf _NPROCESSORS_ONLN) |
There was a problem hiding this comment.
This comes from the setup-helper-functions sourcing.
|
|
||
| function install_duckdb { | ||
| if $BUILD_DUCKDB ; then | ||
| echo 'Building DuckDB' |
|
|
||
| # install azure-storage-files-datalake | ||
| cmake_install sdk/storage/azure-storage-files-datalake -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} -DBUILD_SHARED_LIBS=OFF | ||
| } |
| @@ -30,24 +30,18 @@ set -x # Print commands that are executed. | |||
|
|
|||
| SCRIPTDIR=$(dirname "${BASH_SOURCE[0]}") | |||
| export INSTALL_PREFIX=${INSTALL_PREFIX:-"$(pwd)/deps-install"} | |||
| source $SCRIPTDIR/setup-helper-functions.sh | |||
| source $SCRIPTDIR/setup-common.sh | |||
There was a problem hiding this comment.
This overrides the INSTALL_PREFIX from the previous line to possibly the default /usr/local.
INSTALL_PREFIX is likely something that should be set in each OS separately although the Linux ones share the same location.
| MACOS_VELOX_DEPS="bison flex gflags glog googletest icu4c libevent libsodium lz4 lzo openssl protobuf@21 simdjson snappy thrift xz zstd" | ||
| MACOS_BUILD_DEPS="ninja cmake ccache" | ||
|
|
||
| SUDO="${SUDO:-""}" |
| NLOHMAN_JSON_VERSION="v3.11.3" | ||
| GOOGLE_CLOUD_CPP_VERSION="v2.22.0" | ||
| HADOOP_VERSION="2.10.1" | ||
| AZURE_SDK_VERSION="12.8.0" |
Use a common file to download and install external dependencies.
Extract versions for each library.
This also addresses #10860
xsimd is removed from brew and instead installed using the install function. The issue is caused by xsimd being newer than works for Velox at this point.