refactor(spill): Only use query config to decide prefix sort enable status #12340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69678186 |
✅ Deploy Preview for meta-velox canceled.
|
zation99
changed the title
zation99
changed the title
…cubator#12340) Summary: Right now we have two places for checking whether spill prefixsort is enabled: 1: `QueryConfig::spillPrefixSortEnabled()` that decides based on the worker config 2: `SpillConfig::prefixSortEnabled()` that decides based on `prefixSortConfig.has_value()` 2 depends on 1 based on the assumption that if 1 is false, `prefixSortConfig` is `nullopt`, and this is done through `DriverCtx::makeSpillConfig()` It's better that we only have one source of truth instead of two: checking the worker config. Because the dependency logic is not immediately obvious and may easily break in the future without notice. Differential Revision: D69678186
zation99
force-pushed
the
export-D69678186
branch
from
6b81028 to
df64c7e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69678186 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Right now we have two places for checking whether spill prefixsort is enabled:
1:
QueryConfig::spillPrefixSortEnabled()that decides based on the worker config2:
SpillConfig::prefixSortEnabled()that decides based onprefixSortConfig.has_value()2 depends on 1 based on the assumption that if 1 is false,
prefixSortConfigisnullopt, and this is done throughDriverCtx::makeSpillConfig()It's better that we only have one source of truth instead of two: checking the worker config. Because the dependency logic is not immediately obvious and may easily break in the future without notice.
Differential Revision: D69678186