Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parquet): enable collect statistic for int96 #12357

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat(parquet): enable collect statistic for int96 #12357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b650d50
Create c-cpp.yml
j7nhai Oct 17, 2023
8d84e9f
Merge branch 'facebookincubator:main' into main
j7nhai Aug 4, 2024
5a76a0b
Merge branch 'facebookincubator:main' into main
j7nhai Feb 6, 2025
7f7ef15
Merge branch 'facebookincubator:main' into main
j7nhai Feb 7, 2025
9d1b653
add make script
Feb 7, 2025
8e9919e
Merge remote-tracking branch 'origin'
Feb 7, 2025
d6ffd1f
feat(parquet): enable collect statistic for int96
Feb 17, 2025
366b74e
fix
Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions velox/dwio/parquet/writer/arrow/Statistics.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,11 @@ optional<std::pair<ByteArray, ByteArray>> CleanStatistic(
return min_max;
}

optional<std::pair<Int96, Int96>> CleanStatistic(
std::pair<Int96, Int96> min_max) {
return min_max;
}

template <bool is_signed, typename DType>
class TypedComparatorImpl : virtual public TypedComparator<DType> {
public:
Expand Down Expand Up @@ -1021,6 +1026,8 @@ std::shared_ptr<Statistics> Statistics::Make(
return std::make_shared<TypedStatisticsImpl<Int32Type>>(descr, pool);
case Type::INT64:
return std::make_shared<TypedStatisticsImpl<Int64Type>>(descr, pool);
case Type::INT96:
return std::make_shared<TypedStatisticsImpl<Int96Type>>(descr, pool);
case Type::FLOAT:
return std::make_shared<TypedStatisticsImpl<FloatType>>(descr, pool);
case Type::DOUBLE:
Expand Down
2 changes: 1 addition & 1 deletion velox/dwio/parquet/writer/arrow/Types.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,13 +261,13 @@ SortOrder::type DefaultSortOrder(Type::type primitive) {
case Type::BOOLEAN:
case Type::INT32:
case Type::INT64:
case Type::INT96:
case Type::FLOAT:
case Type::DOUBLE:
return SortOrder::SIGNED;
case Type::BYTE_ARRAY:
case Type::FIXED_LEN_BYTE_ARRAY:
return SortOrder::UNSIGNED;
case Type::INT96:
case Type::UNDEFINED:
return SortOrder::UNKNOWN;
}
Expand Down