Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix dual linking of gflags when CMake variable BUILD_SHARED_LIBS is cached #12359

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Fix dual linking of gflags when CMake variable BUILD_SHARED_LIBS is cached #12359

wants to merge 3 commits into from

Conversation

zhztheplayer
Copy link
Contributor

This fixes #12358.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 17, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 17, 2025 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit a42a56a
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67b5a58f2227870008448d0d

@majetideepak
Copy link
Collaborator

I will let @assignUser review this since he was the original author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@majetideepak majetideepak Awaiting requested review from majetideepak majetideepak is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash due to dual linking of gflags
3 participants
@zhztheplayer @majetideepak @facebook-github-bot