fix: Reduce lock cost in AsciiInfo updates #12363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D69750090 |
facebook-github-bot
added
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Feb 17, 2025
Summary: In some cases (e.g. row-wise deserialization) we need to resize the string vector frequently. In that case none of the ASCII info is valid, but we still pay the price to lock and check the state. Fix the cost by using an atomic boolean for fast path check. Differential Revision: D69750090
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Feb 18, 2025
Summary: In some cases (e.g. row-wise deserialization) we need to resize the string vector frequently. In that case none of the ASCII info is valid, but we still pay the price to lock and check the state. Fix the cost by using an atomic boolean for fast path check. Differential Revision: D69750090
Summary: In some cases (e.g. row-wise deserialization) we need to resize the string vector frequently. In that case none of the ASCII info is valid, but we still pay the price to lock and check the state. Fix the cost by using an atomic boolean for fast path check. Differential Revision: D69750090
Yuhta
force-pushed
the
export-D69750090
branch
from
6a38965 to
3bf339c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69750090 |
|
This pull request has been merged in 381dfcd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In some cases (e.g. row-wise deserialization) we need to resize the
string vector frequently. In that case none of the ASCII info is valid, but we
still pay the price to lock and check the state. Fix the cost by using an
atomic boolean for fast path check.
Differential Revision: D69750090