feat: Add HashStringAllocator::InputStream #12364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69750088 |
✅ Deploy Preview for meta-velox canceled.
|
… map (facebookincubator#12362) Summary: 1. Optimize `deserializeString` in case of inlined strings 2. Optimize `deserializeArray` to avoid heap allocation for intermediate null-like data 3. Inline `FlatVector<StringView>::setNoCopy` Differential Revision: D69750091
Summary: In some cases (e.g. row-wise deserialization) we need to resize the string vector frequently. In that case none of the ASCII info is valid, but we still pay the price to lock and check the state. Fix the cost by using an atomic boolean for fast path check. Differential Revision: D69750090
Summary: When we get `ByteInputStream` from `HashStringAllocator`, we used to have to materialize all the byte ranges in a vector, which is not efficient. This change improves the efficiency by creating a `ByteInputStream` directly over the linked list of a multi-part allocation. Differential Revision: D69750088
Yuhta
force-pushed
the
export-D69750088
branch
from
2be69b0 to
d8f1814
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69750088 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When we get
ByteInputStreamfromHashStringAllocator, we used tohave to materialize all the byte ranges in a vector, which is not efficient.
This change improve the efficiency by creating a
ByteInputStreamdirectly overthe linked list of a multi-part allocation.
Differential Revision: D69750088