feat: Add support for Timestamp to Integral for Spark #12369
+73
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
cc @rui-mo could you please take a look |
| @@ -50,6 +50,21 @@ Expected<Timestamp> SparkCastHooks::castIntToTimestamp(int64_t seconds) const { | |||
| return Timestamp(seconds, 0); | |||
| } | |||
|
|
|||
| Expected<int64_t> SparkCastHooks::castTimestampToInt(Timestamp timestamp) const { | |||
| static constexpr int64_t MICROS_PER_SECOND = 1'000'000; | |||
There was a problem hiding this comment.
Please add kMicroSecondsInSeconds like kNanosInSecond
| @@ -286,6 +286,14 @@ void CastExpr::applyCastKernel( | |||
| return; | |||
| } | |||
|
|
|||
| if constexpr ( | |||
| (FromKind == TypeKind::TIMESTAMP) && ToKind == TypeKind::BIGINT) { | |||
There was a problem hiding this comment.
What if to kind is int?
| @@ -50,6 +50,21 @@ Expected<Timestamp> SparkCastHooks::castIntToTimestamp(int64_t seconds) const { | |||
| return Timestamp(seconds, 0); | |||
| } | |||
|
|
|||
| Expected<int64_t> SparkCastHooks::castTimestampToInt(Timestamp timestamp) const { | |||
| static constexpr int64_t MICROS_PER_SECOND = 1'000'000; | |||
| int64_t micros = timestamp.toMicros(); | |||
rui-mo
reviewed
Feb 18, 2025
| @@ -97,6 +97,11 @@ Expected<int32_t> PrestoCastHooks::castStringToDate( | |||
| return util::fromDateString(dateString, util::ParseMode::kPrestoCast); | |||
| } | |||
|
|
|||
| Expected<int64_t> PrestoCastHooks::castTimestampToInt(Timestamp timestamp) const { | |||
| return folly::makeUnexpected( | |||
There was a problem hiding this comment.
Have we verified in Presto that this conversion is indeed unsupported?
| @@ -32,6 +32,9 @@ class PrestoCastHooks : public CastHooks { | |||
|
|
|||
| Expected<Timestamp> castIntToTimestamp(int64_t seconds) const override; | |||
|
|
|||
| // Cast timestamp to integer. | |||
| Expected<int64_t> castTimestampToInt(Timestamp timestamp) const override; | |||
There was a problem hiding this comment.
It appears that we are converting timestamp as big int not integer. Perhaps use consistent function name, and avoid repeating the name in comment.
| Timestamp(-1, 1), | ||
| Timestamp(1234567, 500000), | ||
| Timestamp(-9876543, 1234), | ||
| std::nullopt, |
There was a problem hiding this comment.
Perhaps remove the null test as it tests the framework not the function itself.
|
Duplicated with #11468 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?