feat: Handle errors during constant folding in expression compilation #12376
+57
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -1753,9 +1753,11 @@ std::vector<common::Subfield> Expr::extractSubfields() const { | |||
| ExprSet::ExprSet( | |||
| const std::vector<core::TypedExprPtr>& sources, | |||
| core::ExecCtx* execCtx, | |||
| bool enableConstantFolding) | |||
| bool enableConstantFolding, | |||
| bool ignoreConstantFoldError) | |||
There was a problem hiding this comment.
@pramodsatya : Maybe say 'constantFoldErrorWithFailFunction' instead to make the config more clear about what it does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expression compilation currently ignores any errors encountered during constant folding. This change enables the expression compiler to return a
FailFunctionin place of the constant expression which throws aVeloxExceptionwhen evaluated. This is consistent with the behavior of Presto's expression compiler, please see this issue for more context.