Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove more unnecessary PTX code from Wave #12380

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Remove more unnecessary PTX code from Wave #12380

wants to merge 3 commits into from

Conversation

dreveman
Copy link
Collaborator

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 18, 2025
@dreveman dreveman requested review from Yuhta and removed request for majetideepak and assignUser February 18, 2025 21:38
@netlify Netlify
Copy link

netlify bot commented Feb 18, 2025 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 540a750
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67b6155f183ff400084df04a

David Reveman added 2 commits February 18, 2025 16:45
feat: Implement LaneId without using PTX
bfbf4ea 
Shouldn't impact performance. If anything, might be faster as
threadIdx.x is likely in a register already and %laneid requires
a S2R instruction that can have a relatively long latency
compared to a regular register.
feat: Do not require nvcc to compile CUDA code
6a9aac0
@dreveman dreveman changed the title feat: remove more unnecessary PTX code from Wave feat: Remove more unnecessary PTX code from Wave Feb 18, 2025
Yuhta
Yuhta reviewed Feb 19, 2025
View reviewed changes
@Yuhta Yuhta added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Feb 19, 2025
build: Add VELOX_SKIP_WAVE_BRANCH_KERNEL_TEST ifdef
540a750 
Add build option that disables Wave branch kernel test as
it requires PTX. This test is enabled by default and can be
disabled with:

cmake -DVELOX_SKIP_WAVE_BRANCH_KERNEL_TEST=ON
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuhta Yuhta Yuhta approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreveman @Yuhta @facebook-github-bot