misc(fuzzer): Add stats about verification against reference DB in expression fuzzer #12383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D69819014 |
facebook-github-bot
added
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
peterenescu
reviewed
Feb 19, 2025
| @@ -462,8 +479,13 @@ void ExpressionFuzzerVerifier::go() { | |||
| } | |||
| logStats(); | |||
|
|
|||
| LOG(ERROR) << "Total iterations: " << i; | |||
| LOG(ERROR) << "Total failed: " << numFailed; | |||
| LOG(ERROR) << "Total test cases: " << totalTestCases; | |||
There was a problem hiding this comment.
Should these be considered error messages even though they're just runs stats?
There was a problem hiding this comment.
Hi @peterenescu, thank you for reviewing! This logging to stderr is actually intended, so that we can see the stats directly on screen in Github CI jobs (because we save stdout to files and only show stderr in screen for CI jobs). See the recent change in #12328.
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Feb 20, 2025
…pression fuzzer (facebookincubator#12383) Summary: This diffs add stats reported by the expression fuzzer about how many test cases are verified against Presto and how many fail in both Velox and the reference DB. Differential Revision: D69819014
kagamiori
force-pushed
the
export-D69819014
branch
from
aca0190 to
848d478
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69819014 |
…pression fuzzer (facebookincubator#12383) Summary: This diffs add stats reported by the expression fuzzer about how many test cases are verified against Presto and how many fail in both Velox and the reference DB. Differential Revision: D69819014
kagamiori
force-pushed
the
export-D69819014
branch
from
848d478 to
ef90786
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69819014 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diffs add stats reported by the expression fuzzer about how many test cases are verified against Presto and how many fail in both Velox and the reference DB.
Differential Revision: D69819014