misc(fuzzer): remove verifyWindow() in AggregationFuzzer #12391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We used to test window operations in aggregaiton fuzzer before the window fuzzer was built. Since we now have a window fuzzer that has much better coverage, remove the verifyWindow method in AggregationFuzzer. Differential Revision: D69886065
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69886065 |
✅ Deploy Preview for meta-velox canceled.
|
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Feb 20, 2025
…ubator#12391) Summary: We used to test window operations in aggregaiton fuzzer before the window fuzzer was built. Since we now have a window fuzzer that has much better coverage, remove the verifyWindow method in AggregationFuzzer. Differential Revision: D69886065
natashasehgal
approved these changes
Feb 20, 2025
| // 10% of times test window operator. | ||
| const bool sortedInputs = FLAGS_enable_sorted_aggregations && | ||
| canSortInputs(signature) && vectorFuzzer_.coinToss(0.2); | ||
|
|
There was a problem hiding this comment.
Why was the removal of 10% window fuzzer replaced by 0.2 coin tosses ?
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Feb 21, 2025
…ubator#12391) Summary: We used to test window operations in aggregaiton fuzzer before the window fuzzer was built. Since we now have a window fuzzer that has much better coverage, remove the verifyWindow method in AggregationFuzzer. Reviewed By: natashasehgal Differential Revision: D69886065
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We used to test window operations in aggregaiton fuzzer before the window fuzzer was built. Since
we now have a window fuzzer that has much better coverage, remove the verifyWindow method in
AggregationFuzzer.
Differential Revision: D69886065