feat: Spark get_json_object function support incomplete json #12417
+27
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoluan2009
requested review from
assignUser and
majetideepak
as code owners
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
PHILO-HE
reviewed
Feb 21, 2025
There was a problem hiding this comment.
Pasted simdjson's pr link for this incomplete json support: simdjson/simdjson#2189. It's an experimental functionality.
Not sure whether there will be any side effect for Spark workload. It would be better to add more incomplete json cases in test and verify the result with vanilla Spark.
| @@ -47,4 +47,9 @@ void simdjsonErrorsToExceptions( | |||
| simdjson::simdjson_result<simdjson::ondemand::document> simdjsonParse( | |||
| const simdjson::padded_string_view& json); | |||
|
|
|||
| /// Parse the input incomplete json string using a thread local on demand | |||
There was a problem hiding this comment.
/// Parse the input json string using a thread local on demand parser. Allow incomplete json input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spark get_json_object support incomplete json, for example :
select get_json_object('{"hello": "3.5"},', '$.'hello)will return 3.5, but velox will return null