Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeKind::HUGEINT to Type dispatch templates #4828

Closed
wants to merge 1 commit into from
Closed

Add TypeKind::HUGEINT to Type dispatch templates #4828

wants to merge 1 commit into from

Conversation

majetideepak
Copy link
Collaborator

@majetideepak majetideepak commented May 4, 2023 •
edited
Loading

Add TypeKind::HUGEINT support in
VELOX_DYNAMIC_SCALAR_TEMPLATE_TYPE_DISPATCH
VELOX_DYNAMIC_TYPE_DISPATCH_IMPL
VELOX_DYNAMIC_SCALAR_TYPE_DISPATCH

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 4, 2023
@netlify
Copy link

netlify bot commented May 4, 2023 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 393a524
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/647a1ca33950910008e8a7a9

@majetideepak majetideepak changed the title Add HUGEINT TypeKind to dispatch template Add HUGEINT TypeKind to dispatch templates May 4, 2023
@majetideepak majetideepak changed the title Add HUGEINT TypeKind to dispatch templates Add TypeKind::HUGEINT to dispatch templates May 4, 2023
@majetideepak majetideepak changed the title Add TypeKind::HUGEINT to dispatch templates Add TypeKind::HUGEINT to Type dispatch templates May 8, 2023
@majetideepak majetideepak force-pushed the hugeint-support branch 3 times, most recently from b594ef6 to 1a85e27 Compare May 8, 2023 11:22
@majetideepak majetideepak mentioned this pull request May 8, 2023
Closed
@majetideepak majetideepak marked this pull request as ready for review May 9, 2023 05:48
@majetideepak
Copy link
Collaborator Author

Need #4864 for the linux-adapters CI to pass.

assignUser
assignUser reviewed May 10, 2023
View reviewed changes
scripts/setup-macos.sh Outdated
@@ -94,7 +94,7 @@ function install_fmt {
function install_folly {
github_checkout facebook/folly "v2022.11.14.00"
OPENSSL_ROOT_DIR=$(brew --prefix [email protected]) \
cmake_install -DBUILD_TESTS=OFF
cmake_install -DBUILD_TESTS=OFF -DFOLLY_HAVE_INT128_T=ON
Copy link
Collaborator

@assignUser assignUser May 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be added to the other setup-* scripts as well! That should solve some off the ci issues.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. Thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linux wheels (and any not running the script during the run) will fail as long as the docker image is not rebuild

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #4864 to rebuild the docker image.

@majetideepak majetideepak requested a review from kgpai June 1, 2023 17:30
@majetideepak majetideepak force-pushed the hugeint-support branch 2 times, most recently from a2cf14a to 16a41ff Compare June 2, 2023 09:57
@kgpai
Copy link
Contributor

kgpai commented Jun 2, 2023

@majetideepak The failure in pyVelox is because I think it uses bundled folly without hugeint support. Might need a change in setup.py:build_extension to pass right flags to fix this.
cc @assignUser

@majetideepak
Copy link
Collaborator Author

majetideepak commented Jun 2, 2023 •
edited
Loading

@kgpai I likely did not rebase this branch after the script changes. I pushed again after rebasing. Let's see if that fixes the CI job.

@majetideepak
Copy link
Collaborator Author

@kgpai it now passes. Can you please help review/merge?

@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kgpai
Copy link
Contributor

kgpai commented Jun 6, 2023

@majetideepak Please give me a day or two to merge this as it requires some changes internally.

@majetideepak
Copy link
Collaborator Author

@kgpai thank you for the update!

@facebook-github-bot
Copy link
Contributor

@kgpai merged this pull request in 9c4e901.

@conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit 9c4e9013.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

@amitkdutta amitkdutta mentioned this pull request Jun 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assignUser assignUser assignUser left review comments

@kgpai kgpai kgpai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@majetideepak @kgpai @facebook-github-bot @assignUser