-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better format for cage source ls
#63
base: master
Are you sure you want to change the base?
Conversation
...aaaand looks like I need to fix the mount check :( |
OK, fixed mounted check |
@dkastner what did the old format look like for comparison? |
The "mounted" note is hard to see at a glance. Also, the multiline format makes it hard to grep |
this looks great to me! |
I'm not a huge fan of massive, multi-column tables that wrap on 80-character terminals. Can we think of any alternate ways to present this information? I'd be OK with two formats, one for writing to TTYs and one for writing to pipes, or a JSON format that could be passed to |
This is the same kind of format |
@dkastner The fact that Docker displays tables that don't respect terminal width limits the way regular |
I spoke with @dkastner about this again today, and I'm still leaning against supporting >80 char table output. Instead, it might be possible to do something like the following: sudo npm install -g json2csv
cargo install xsv ...and adding a cage source ls --json | json2csv -f name,mounted | xsv table (Optionally, However, this raises a related workflow issue, which is that we need some super-easy way to list just the mounted sources. I'd also be happy to support: # One of the following?
cage source ls --mounted
cage source mounted ...or any reasonable variation on that theme. |
I've found that the display format of the old
cage source ls
was difficult to grok at a glance.Here's a new, one-row-per-service format: